lkml.org 
[lkml]   [2015]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 00/13] High performance balancing logic for big.LITTLE

No, no, no, no.

This is horrible and exactly what I've been telling people I do not want
to see.

This is very arch specific scheduler code, and very badly done. It
doesn't even call the groups big and little, it goes so far as to put a7
and a15 in sched domain member names.

It doesn't get topology information from device tree but from hard coded
CONFIG strings.

It introduces a swap_task function while we already have one.

It doesn't integrate with any of the other bits that make up and
influence energy consumption such as cpuidle and cpufreq (very minor one
way).

It doesn't mention the existing energy-aware-scheduling effort, nor how
that approach cannot be made to work for this.

It has a completely broken SoB chain.

It introduces new metrics (like druntime) without first defining them;
and in general very poor Changelogs.

In general, this makes me very sad. Please start by participating in the
existing discussion.


\
 
 \ /
  Last update: 2015-11-07 11:21    [W:0.078 / U:14.432 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site