lkml.org 
[lkml]   [2015]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4.2 073/110] i2c: mv64xxx: really allow I2C offloading
From
Date
On Fri, 2015-11-06 at 11:19 -0800, Greg Kroah-Hartman wrote:
> 4.2-stable review patch.  If anyone has any objections, please let me know.
>
> ------------------
>
> From: Hezi Shahmoon <hezi@marvell.com>
>
> commit 0729a04977d497cf66234fd7f900ddcec3ef1c52 upstream.
>
> Commit 00d8689b85a7 ("i2c: mv64xxx: rework offload support to fix
> several problems") completely reworked the offload support, but left a
> debugging-related "return false" at the beginning of the
> mv64xxx_i2c_can_offload() function. This has the unfortunate consequence
> that offloading is in fact never used, which wasn't really the
> intention.
>
> This commit fixes that problem by removing the bogus "return false".

This looks like enabling a feature rather than fixing a bug.  As it's
not a critical feature, this doesn't seem suitable for stable.

Ben.

> Fixes: 00d8689b85a7 ("i2c: mv64xxx: rework offload support to fix several problems")
> Signed-off-by: Hezi Shahmoon <hezi@marvell.com>
> [Thomas: reworked commit log and title.]
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> ---
>  drivers/i2c/busses/i2c-mv64xxx.c |    2 --
>  1 file changed, 2 deletions(-)
>
> --- a/drivers/i2c/busses/i2c-mv64xxx.c
> +++ b/drivers/i2c/busses/i2c-mv64xxx.c
> @@ -669,8 +669,6 @@ mv64xxx_i2c_can_offload(struct mv64xxx_i
>  > > struct i2c_msg *msgs = drv_data->msgs;
>  > > int num = drv_data->num_msgs;
>  
> -> > return false;
> -
>  > > if (!drv_data->offload_enabled)
>  > > > return false;
>  
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
Ben Hutchings
73.46% of all statistics are made up.[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-11-07 17:41    [W:0.609 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site