lkml.org 
[lkml]   [2015]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] mm: add page_check_address_transhuge helper
    On Fri, Nov 06, 2015 at 05:37:07PM +0300, Vladimir Davydov wrote:
    > diff --git a/mm/rmap.c b/mm/rmap.c
    > index 0837487d3737..7ac775e41820 100644
    > --- a/mm/rmap.c
    > +++ b/mm/rmap.c
    > @@ -796,48 +796,43 @@ int page_mapped_in_vma(struct page *page, struct vm_area_struct *vma)
    > return 1;
    > }
    >
    > -struct page_referenced_arg {
    > - int mapcount;
    > - int referenced;
    > - unsigned long vm_flags;
    > - struct mem_cgroup *memcg;
    > -};
    > /*
    > - * arg: page_referenced_arg will be passed
    > + * Check that @page is mapped at @address into @mm. In contrast to
    > + * page_check_address(), this function can handle transparent huge pages.
    > + *
    > + * On success returns true with pte mapped and locked. For transparent huge
    > + * pages *@ptep is set to NULL.

    I think

    "For PMD-mapped transparent huge pages"...

    would be more correct.

    Otherwise looks great!

    Reviewed-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

    --
    Kirill A. Shutemov


    \
     
     \ /
      Last update: 2015-11-06 16:41    [W:3.738 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site