Messages in this thread | | | Subject | Re: [PATCH v1] mm: hwpoison: adjust for new thp refcounting | From | Sasha Levin <> | Date | Fri, 6 Nov 2015 01:31:49 -0500 |
| |
On 11/06/2015 01:11 AM, Naoya Horiguchi wrote: > In the new refcounting, we no longer use tail->_mapcount to keep tail's > refcount, and thereby we can simplify get_hwpoison_page() and remove > put_hwpoison_page() (by replacing with put_page()).
This is confusing for the reader (and some static analysis tools): this adds put_page()s without corresponding get_page()s.
Could we instead macro put_hwpoison_page() as put_page() for the sake of readability?
Thanks, Sasha
| |