lkml.org 
[lkml]   [2015]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/3] ASoC: rockchip: i2s: add 8 channels capture support
On Fri, Nov 06, 2015 at 09:38:09AM +0800, Sugar Zhang wrote:

> + /* refine capture channels */
> + if (!of_property_read_u32(node, "rockchip,capture-channels", &val)) {
> + if (val >= 2 && val <= 8)
> + rockchip_i2s_dai.capture.channels_max = val;
> + else
> + rockchip_i2s_dai.capture.channels_max = 2;
> + }

You should make a copy of the rockchip_i2s_dai struct in your driver
data and modify that rather than modifying the original - what happens
if sommeone makes a SoC with two I2S DAIs, one with many channels and
another with only two? Samsung SoCs often have an arrangement like that
for exmaple.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-11-06 13:21    [W:0.042 / U:1.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site