Messages in this thread | | | Date | Thu, 5 Nov 2015 16:43:52 -0800 | Subject | Re: [GIT] Sparc | From | Linus Torvalds <> |
| |
On Thu, Nov 5, 2015 at 1:39 PM, David Miller <davem@davemloft.net> wrote: > > 5) Fix iommu-common code so it doesn't emit rediculous warnings > on some architectures, particularly ARM.
Heh. So looking at that patch, I can't but help to react that this:
#define IOMMU_ERROR_CODE (~(unsigned long) 0)
is still pretty ridiculous. Maybe just (-1ul), or for those people who don't understand C unsigned long arithmetic and think that a negative unsigned long looks odd, (~0ul)?
Not that this *matters*, but it's a bit odd to have to cast constants to perfectly regular C types.
Linus
| |