lkml.org 
[lkml]   [2015]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] IPC-mqueue: Delete unnecessary checks before two function calls
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 5 Nov 2015 17:55:25 +0100

    The functions iput() and unregister_sysctl_table() test whether their
    argument is NULL and then return immediately.
    Thus the tests around their calls are not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    ipc/mqueue.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/ipc/mqueue.c b/ipc/mqueue.c
    index 161a180..ade9dd8 100644
    --- a/ipc/mqueue.c
    +++ b/ipc/mqueue.c
    @@ -885,8 +885,7 @@ SYSCALL_DEFINE1(mq_unlink, const char __user *, u_name)

    out_unlock:
    mutex_unlock(&d_inode(mnt->mnt_root)->i_mutex);
    - if (inode)
    - iput(inode);
    + iput(inode);
    mnt_drop_write(mnt);
    out_name:
    putname(name);
    @@ -1460,8 +1459,7 @@ static int __init init_mqueue_fs(void)
    out_filesystem:
    unregister_filesystem(&mqueue_fs_type);
    out_sysctl:
    - if (mq_sysctl_table)
    - unregister_sysctl_table(mq_sysctl_table);
    + unregister_sysctl_table(mq_sysctl_table);
    kmem_cache_destroy(mqueue_inode_cachep);
    return error;
    }
    --
    2.6.2


    \
     
     \ /
      Last update: 2015-11-05 18:21    [W:4.026 / U:0.260 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site