lkml.org 
[lkml]   [2015]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] pinctrl: Delete unnecessary checks before the function call "pinctrl_unregister"
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 5 Nov 2015 17:10:22 +0100

    The pinctrl_unregister() function tests whether its argument is NULL
    and then returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/pinctrl/bcm/pinctrl-cygnus-gpio.c | 3 +--
    drivers/pinctrl/pinctrl-single.c | 5 +----
    2 files changed, 2 insertions(+), 6 deletions(-)

    diff --git a/drivers/pinctrl/bcm/pinctrl-cygnus-gpio.c b/drivers/pinctrl/bcm/pinctrl-cygnus-gpio.c
    index 12a48f4..663ad0a 100644
    --- a/drivers/pinctrl/bcm/pinctrl-cygnus-gpio.c
    +++ b/drivers/pinctrl/bcm/pinctrl-cygnus-gpio.c
    @@ -638,8 +638,7 @@ static int cygnus_gpio_register_pinconf(struct cygnus_gpio *chip)

    static void cygnus_gpio_unregister_pinconf(struct cygnus_gpio *chip)
    {
    - if (chip->pctl)
    - pinctrl_unregister(chip->pctl);
    + pinctrl_unregister(chip->pctl);
    }

    struct cygnus_gpio_data {
    diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
    index ef04b96..d24e5f1 100644
    --- a/drivers/pinctrl/pinctrl-single.c
    +++ b/drivers/pinctrl/pinctrl-single.c
    @@ -1484,10 +1484,7 @@ static void pcs_irq_free(struct pcs_device *pcs)
    static void pcs_free_resources(struct pcs_device *pcs)
    {
    pcs_irq_free(pcs);
    -
    - if (pcs->pctl)
    - pinctrl_unregister(pcs->pctl);
    -
    + pinctrl_unregister(pcs->pctl);
    pcs_free_funcs(pcs);
    pcs_free_pingroups(pcs);
    }
    --
    2.6.2


    \
     
     \ /
      Last update: 2015-11-05 17:41    [W:4.073 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site