Messages in this thread | | | Date | Thu, 5 Nov 2015 13:45:08 +0800 | From | kbuild test robot <> | Subject | Re: [PATCH] alarmtimer: fix unexpected rtc interrupt when system resume |
| |
Hi zhuo-hao,
[auto build test WARNING on: tip/timers/core] [also build test WARNING on: v4.3 next-20151104]
url: https://github.com/0day-ci/linux/commits/zhuo-hao-lee-intel-com/alarmtimer-fix-unexpected-rtc-interrupt-when-system-resume/20151105-124811 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> kernel/time/alarmtimer.c:280:20: sparse: incompatible types in conditional expression (different base types) kernel/time/alarmtimer.c: In function 'alarmtimer_resume': kernel/time/alarmtimer.c:280:9: error: void value not ignored as it ought to be return rtc ? rtc_timer_cancel(rtc, &rtctimer) : 0; ^ kernel/time/alarmtimer.c:281:1: warning: control reaches end of non-void function [-Wreturn-type] } ^
vim +280 kernel/time/alarmtimer.c
264 rtc_read_time(rtc, &tm); 265 now = rtc_tm_to_ktime(tm); 266 now = ktime_add(now, min); 267 268 /* Set alarm, if in the past reject suspend briefly to handle */ 269 ret = rtc_timer_start(rtc, &rtctimer, now, ktime_set(0, 0)); 270 if (ret < 0) 271 __pm_wakeup_event(ws, MSEC_PER_SEC); 272 return ret; 273 } 274 275 static int alarmtimer_resume(struct device *dev) 276 { 277 struct rtc_device *rtc; 278 279 rtc = alarmtimer_get_rtcdev(); > 280 return rtc ? rtc_timer_cancel(rtc, &rtctimer) : 0; 281 } 282 283 #else 284 static int alarmtimer_suspend(struct device *dev) 285 { 286 return 0; 287 } 288
--- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
| |