Messages in this thread | | | Date | Thu, 5 Nov 2015 08:40:55 +0900 | From | Minchan Kim <> | Subject | Re: [PATCH v2 01/13] mm: support madvise(MADV_FREE) |
| |
On Wed, Nov 04, 2015 at 11:29:51AM +0900, Sergey Senozhatsky wrote: > On (11/04/15 10:25), Minchan Kim wrote: > [..] > > +static int madvise_free_pte_range(pmd_t *pmd, unsigned long addr, > > + unsigned long end, struct mm_walk *walk) > > + > > +{ > > + struct mmu_gather *tlb = walk->private; > > + struct mm_struct *mm = tlb->mm; > > + struct vm_area_struct *vma = walk->vma; > > + spinlock_t *ptl; > > + pte_t *pte, ptent; > > + struct page *page; > > > I'll just ask (probably I'm missing something) > > + pmd_trans_huge_lock() ?
No. It would be deadlock.
> > > + split_huge_page_pmd(vma, addr, pmd); > > + if (pmd_trans_unstable(pmd)) > > + return 0; > > + > > + pte = pte_offset_map_lock(mm, pmd, addr, &ptl); > > + arch_enter_lazy_mmu_mode(); > > + for (; addr != end; pte++, addr += PAGE_SIZE) { > > + ptent = *pte; > > + > > + if (!pte_present(ptent)) > > + continue; > > + > > + page = vm_normal_page(vma, addr, ptent); > > + if (!page) > > + continue; > > + > > -ss > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
| |