lkml.org 
[lkml]   [2015]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/2] efirtc: add efi_enabled check in efi_rtc_init
Date
On Wednesday 04 November 2015 22:45:42 Geliang Tang wrote:
> On Mon, Nov 02, 2015 at 04:37:51PM +0100, Arnd Bergmann wrote:
> > On Monday 02 November 2015 22:49:01 Geliang Tang wrote:
> > > diff --git a/drivers/char/efirtc.c b/drivers/char/efirtc.c
> > > index 5323d8c..80058bd 100644
> > > --- a/drivers/char/efirtc.c
> > > +++ b/drivers/char/efirtc.c
> > > @@ -378,6 +378,9 @@ efi_rtc_init(void)
> > > int ret;
> > > struct proc_dir_entry *dir;
> > >
> > > + if (!efi_enabled(EFI_RUNTIME_SERVICES))
> > > + return 0;
> > >
> >
> > Are there any Itanium machines that don't enable runtime services?
> > This seems a little redundant otherwise.
> >
> > Are you trying to run the ancient driver on non-Itanium systems?
>
> Yes. I did run this driver on a EFI-based X86_64 machine.

There should already be a Kconfig dependency that prevents you from
doing this. Just use the normal rtc-efi driver instead of the
old efirtc driver.

Arnd


\
 
 \ /
  Last update: 2015-11-04 16:01    [W:0.125 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site