Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 2/2] efirtc: add efi_enabled check in efi_rtc_init | Date | Wed, 04 Nov 2015 15:51:46 +0100 |
| |
On Wednesday 04 November 2015 22:45:42 Geliang Tang wrote: > On Mon, Nov 02, 2015 at 04:37:51PM +0100, Arnd Bergmann wrote: > > On Monday 02 November 2015 22:49:01 Geliang Tang wrote: > > > diff --git a/drivers/char/efirtc.c b/drivers/char/efirtc.c > > > index 5323d8c..80058bd 100644 > > > --- a/drivers/char/efirtc.c > > > +++ b/drivers/char/efirtc.c > > > @@ -378,6 +378,9 @@ efi_rtc_init(void) > > > int ret; > > > struct proc_dir_entry *dir; > > > > > > + if (!efi_enabled(EFI_RUNTIME_SERVICES)) > > > + return 0; > > > > > > > Are there any Itanium machines that don't enable runtime services? > > This seems a little redundant otherwise. > > > > Are you trying to run the ancient driver on non-Itanium systems? > > Yes. I did run this driver on a EFI-based X86_64 machine.
There should already be a Kconfig dependency that prevents you from doing this. Just use the normal rtc-efi driver instead of the old efirtc driver.
Arnd
| |