Messages in this thread | | | Date | Wed, 4 Nov 2015 03:30:19 -0800 | From | Christoph Hellwig <> | Subject | Re: [PATCH] block: Don't allow illegal discard requests |
| |
On Wed, Nov 04, 2015 at 10:18:41AM +0100, Jan Kara wrote: > Currently blkdev_issue_discard() doesn't check that submitted discard > request matches granularity required by the underlying device. > Submitting such requests to the device can have unexpected consequences > (e.g. brd driver just discards more / less data depending on how exactly > the request is aligned). So test that submitted discard request has the > granularity required by the driver.
How is this going to work with stacked drivers? I think brd needs to be fixed to take care of the granularity itself, just like we did for request based drivers.
| |