Messages in this thread | | | Date | Mon, 30 Nov 2015 17:53:18 -0500 | From | Tejun Heo <> | Subject | Re: [PATCH 1/8] kernfs: Add API to generate relative kernfs path |
| |
Hello, Serge.
On Mon, Nov 30, 2015 at 12:37:58PM -0600, Serge E. Hallyn wrote: > > Yeah, I agree but the name is kinda misleading tho. The output isn't > > really a relative path but rather absolute path against the specified > > root. Maybe updating the function and parameter names would be > > helpful? > > > > Ok - updating the comment is simple enough. Though the name/params > kernfs_path_from_node_locked(from, to) still seem to make sense. Would > you prefer something like kernfs_absolute_path_from node_locked()? I > hesitate to call 'from' 'root' since kernfs_root is a thing and this > is not that.
Hmmm... I see. Let's just make sure that the comment is clear about the fact that it calculates (pseudo) absolute path rather than relative path.
Thanks.
-- tejun
| |