Messages in this thread | | | Date | Mon, 30 Nov 2015 11:02:15 +0100 | From | Cornelia Huck <> | Subject | Re: [PATCH] tools/virtio: fix byteswap logic |
| |
On Mon, 30 Nov 2015 10:33:34 +0200 "Michael S. Tsirkin" <mst@redhat.com> wrote:
> commit cf561f0d2eb74574ad9985a2feab134267a9d298 ("virtio: introduce > virtio_is_little_endian() helper") changed byteswap logic to > skip feature bit checks for LE platforms, but didn't > update tools/virtio, so vring_bench started failing. > > Update the copy under tools/virtio/ (TODO: find a way to avoid this code > duplication).
Not to mention that it is easy to miss the code duplication...
> > Cc: Greg Kurz <gkurz@linux.vnet.ibm.com> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > --- > tools/virtio/linux/virtio_config.h | 20 +++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-)
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
| |