Messages in this thread | | | Date | Tue, 3 Nov 2015 10:15:18 -0800 | From | Jeremiah Mahler <> | Subject | Re: [BUG, bisect] i2c: designware: Move common probe code into i2c_dw_probe() |
| |
Jarkko,
On Tue, Nov 03, 2015 at 09:28:55AM +0200, Jarkko Nikula wrote: > Hi > > On 03.11.2015 06:02, Jeremiah Mahler wrote: > >Jarkko, all, > > > >Commit d80d134182ba5 introduced a bug which causes a cyapa based touch > >pad on an Acer C720 Chromebook to become inoperative. This is present > >in the latest linux-next (20151101). The patch description is repeated > >below. > > [...] > Oh, I didn't notice adapter name was used > drivers/platform/chrome/chromeos_laptop.c. Could you try does a patch below > help? > > ============================ CUT HERE ============================ > diff --git a/drivers/platform/chrome/chromeos_laptop.c > b/drivers/platform/chrome/chromeos_laptop.c > index 02072749fff3..2b441e9ae593 100644 > --- a/drivers/platform/chrome/chromeos_laptop.c > +++ b/drivers/platform/chrome/chromeos_laptop.c > @@ -47,8 +47,8 @@ static const char *i2c_adapter_names[] = { > "SMBus I801 adapter", > "i915 gmbus vga", > "i915 gmbus panel", > - "i2c-designware-pci", > - "i2c-designware-pci", > + "Synopsys DesignWare I2C adapter", > + "Synopsys DesignWare I2C adapter", > }; > > /* Keep this enum consistent with i2c_adapter_names */ > ============================ CUT HERE ============================ > > -- > Jarkko > --
Yes, that change fixes the problem. Thanks for the quick fix.
Tested-by: Jeremiah Mahler <jmmahler@gmail.com>
So the find_i2c_adapter_num function was looking for "i2c-designware-pci" but it should have been looking for "Synopsys DesignWare I2C adapter". Where does this bus name come from, is it read from the device itself?
-- - Jeremiah Mahler
| |