lkml.org 
[lkml]   [2015]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v13 22/51] xfs: Fix error path in xfs_get_acl
    Date
    Error codes from xfs_attr_get other than -ENOATTR were not properly
    reported. Fix that.

    In addition, the declaration of struct xfs_inode in xfs_acl.h isn't needed.

    Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
    ---
    fs/xfs/xfs_acl.c | 1 +
    fs/xfs/xfs_acl.h | 1 -
    2 files changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/xfs/xfs_acl.c b/fs/xfs/xfs_acl.c
    index 4b64167..e87fd3f 100644
    --- a/fs/xfs/xfs_acl.c
    +++ b/fs/xfs/xfs_acl.c
    @@ -160,6 +160,7 @@ xfs_get_acl(struct inode *inode, int type)
    */
    if (error == -ENOATTR)
    goto out_update_cache;
    + acl = ERR_PTR(error);
    goto out;
    }

    diff --git a/fs/xfs/xfs_acl.h b/fs/xfs/xfs_acl.h
    index 3841b07..9ee0a0d 100644
    --- a/fs/xfs/xfs_acl.h
    +++ b/fs/xfs/xfs_acl.h
    @@ -20,7 +20,6 @@

    struct inode;
    struct posix_acl;
    -struct xfs_inode;

    #ifdef CONFIG_XFS_POSIX_ACL
    extern struct posix_acl *xfs_get_acl(struct inode *inode, int type);
    --
    2.5.0


    \
     
     \ /
      Last update: 2015-11-03 17:21    [W:2.442 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site