lkml.org 
[lkml]   [2015]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [patch, v2] blk-mq: avoid excessive boot delays with large lun counts
Date
Ming Lei <tom.leiming@gmail.com> writes:

>>> The above should be 'else if', otherwise the current queue will be set
>>> twice.
>>
>> I moved the list add below this to avoid that very issue. See:
>>
>>>> + queue_set_hctx_shared(q, true);
>>>> list_add_tail(&q->tag_set_list, &set->tag_list);
>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>
>> This seemed the cleanest way to structure the code to avoid the double
>> walking of the hctx list for the current q.
>
> OK, it is correct, then v1 is fine.
>
> Reviewed-by: Ming Lei <ming.lei@canonical.com>

Thanks, Ming. Jens, I'll re-send with the list_is_singular change and
this one should be ready for merging.

Cheers,
Jeff


\
 
 \ /
  Last update: 2015-11-03 14:41    [W:0.087 / U:1.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site