Messages in this thread | | | Subject | Re: [PATCH v2] pwm-backlight: fix the panel power sequence | From | Philipp Zabel <> | Date | Tue, 03 Nov 2015 12:08:44 +0100 |
| |
Hi YH,
Am Dienstag, den 03.11.2015, 16:11 +0800 schrieb YH Huang: > > The reasoning is that devices where there is no phandle link pointing to > > the backlight (for example from a simple-panel node), we should keep the > > current default behaviour (enable during probe). > > I have a little problem for the current default behaviour. > Should we enable during probe?
Here I mean enabling the backlight (at the end of the probe function), not enabling the GPIO already when requesting it.
> Before this patch ( http://patchwork.ozlabs.org/patch/324690/ ), > we disable "enable-gpio" in the probe function.
While before this patch the GPIO would be initialized in the disabled state, the call to backlight_update_status at the end of the probe function would still enable the backlight afterwards.
regards Philipp
| |