Messages in this thread Patch in this message | | | Date | Sun, 29 Nov 2015 22:47:16 +0100 | From | Willy Tarreau <> | Subject | [PATCH 2.6.32 14/38] [PATCH 14/38] devres: fix devres_get() |
| |
2.6.32-longterm review patch. If anyone has any objections, please let me know.
------------------
commit 64526370d11ce8868ca495723d595b61e8697fbf upstream.
Currently, devres_get() passes devres_free() the pointer to devres, but devres_free() should be given with the pointer to resource data.
Fixes: 9ac7849e35f7 ("devres: device resource management") Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Acked-by: Tejun Heo <tj@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Ben Hutchings <ben@decadent.org.uk> (cherry picked from commit ebc0ae5a7159086a992f7904dc9ad849a13eecfc) Signed-off-by: Willy Tarreau <w@1wt.eu> --- drivers/base/devres.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/base/devres.c b/drivers/base/devres.c index 05dd307..6d022dc 100644 --- a/drivers/base/devres.c +++ b/drivers/base/devres.c @@ -253,10 +253,10 @@ void * devres_get(struct device *dev, void *new_res, if (!dr) { add_dr(dev, &new_dr->node); dr = new_dr; - new_dr = NULL; + new_res = NULL; } spin_unlock_irqrestore(&dev->devres_lock, flags); - devres_free(new_dr); + devres_free(new_res); return dr->data; } -- 1.7.12.2.21.g234cd45.dirty
| |