lkml.org 
[lkml]   [2015]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[bug] mei_fasync() bogosity
in "mei: implement fasync for event notification" a ->fasync() instance is
added as

static int mei_fasync(int fd, struct file *file, int band)
{

struct mei_cl *cl = file->private_data;

if (!mei_cl_is_connected(cl))
return POLLERR;

return fasync_helper(fd, file, band, &cl->ev_async);
}

Valid return values for ->fasync() are 0, 1 and -E...; 8 (aka POLLERR) is not.
What had been intended there? -ENODEV? Some other error? As it is, the
thing is broken.


\
 
 \ /
  Last update: 2015-11-27 05:41    [W:0.471 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site