Messages in this thread | | | Date | Thu, 26 Nov 2015 17:07:18 +0100 | From | Ludovic Desroches <> | Subject | Re: [PATCH v2] mmc: sdhci at91: add PM support |
| |
On Tue, Nov 10, 2015 at 12:12:30PM +0100, Ulf Hansson wrote: > On 10 November 2015 at 11:36, Ludovic Desroches > <ludovic.desroches@atmel.com> wrote: > > Add runtime PM support and use runtime_force_suspend|resume() for system > > PM. > >
[...]
> > static int sdhci_at91_probe(struct platform_device *pdev) > > { > > const struct of_device_id *match; > > @@ -148,6 +206,11 @@ static int sdhci_at91_probe(struct platform_device *pdev) > > if (ret) > > goto clocks_disable_unprepare; > > > > + pm_runtime_set_active(&pdev->dev); > > + pm_runtime_enable(&pdev->dev); > > + pm_runtime_set_autosuspend_delay(&pdev->dev, 50); > > + pm_runtime_use_autosuspend(&pdev->dev); > > Move these four runtime PM calls above sdhci_add_host(), as after that > point the host is used and thus runtime PM operations starts.
Sadly I have discovered a bit late it is not working when doing this because the controller has been suspended before doing the sdhci_add_host().
What is the right way to fix it? Calling pm_runtime_get_noresume() before sdhci_add_host() and calling pm_runtime_put_autosuspend() after?
> > > + > > return 0; > > > > clocks_disable_unprepare: > > @@ -165,6 +228,7 @@ static int sdhci_at91_remove(struct platform_device *pdev) > > struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); > > struct sdhci_at91_priv *priv = pltfm_host->priv; > >
Regards
Ludovic
| |