Messages in this thread | | | Date | Thu, 26 Nov 2015 08:11:05 -0500 | From | Mike Snitzer <> | Subject | Re: block: Always check queue limits for cloned requests |
| |
On Thu, Nov 26 2015 at 2:46am -0500, Hannes Reinecke <hare@suse.de> wrote:
> When a cloned request is retried on other queues it always needs > to be checked against the queue limits of that queue. > Otherwise the calculations for nr_phys_segments might be wrong, > leading to a crash in scsi_init_sgtable(). > > To clarify this the patch renames blk_rq_check_limits() > to blk_cloned_rq_check_limits() and removes the symbol > export, as the new function should only be used for > cloned requests and never exported. > > Cc: Mike Snitzer <snitzer@redhat.com> > Cc: Ewan Milne <emilne@redhat.com> > Cc: Jeff Moyer <jmoyer@redhat.com> > Signed-off-by: Hannes Reinecke <hare@suse.de>
Patch looks good. Thanks for getting to the bottom of this.
Jens, please add these extra tags when you pick this up:
Fixes: e2a60da74 ("block: Clean up special command handling logic") Cc: stable@vger.kernel.org # 3.7+ Acked-by: Mike Snitzer <snitzer@redhat.com>
| |