lkml.org 
[lkml]   [2015]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: checkpatch: GIT_COMMIT_ID rule catches 'cherry picked from commit <sha1>' lines
    From
    Date
    On Wed, 2015-11-25 at 18:15 -0800, Shawn N wrote:
    > Hello,
    >
    > The checkpatch.pl GIT_COMMIT_ID rule appears to be designed to enforce
    > a minimum description when citing patches: 'commit <12+ chars of sha1>
    > (\"\")'. One (unintended?) consequence of this rule is
    > that unmodified 'cherry picked from commit ' (git cherry-pick
    > -x) lines are flagged.
    >
    > - Is the disallowing of 'cherry picked from commit ' lines by
    > GIT_COMMIT_ID working as intended?
    > - If yes, would it be acceptable to instead add a new rule with
    > clearer error output ("Don't include git cherry-pick -x description
    > lines")?
    > - If no (and such lines are actually acceptable) then I will just
    > patch the GIT_COMMIT_ID rule.
    >
    > Thanks,
    >
    > Shawn

    I think sha1 commit ids should always be followed by a
    git commit description.

    If that's not the general consensus, it's pretty easy
    to change.


    \
     
     \ /
      Last update: 2015-11-26 07:21    [W:3.442 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site