Messages in this thread | | | Date | Wed, 25 Nov 2015 10:57:58 +0100 | From | Borislav Petkov <> | Subject | Re: [V5 PATCH 2/4] panic/x86: Allow cpus to save registers even if they are looping in NMI context |
| |
On Wed, Nov 25, 2015 at 09:46:37AM +0000, 河合英宏 / KAWAI,HIDEHIRO wrote: > Does *old* code mean the code without this patch *series* ?
Yes.
> I prefer this, but we might want to add some more prefix or suffix. > For example, "conditionally_run_crash_nmi_callback".
That's unnecessary IMO. If you need to express that, you could write that in a comment above the function definition. Anyone who looks at the code then will know that it is conditional, like so many other kernel functions. :)
> Thanks for your deep review!
Thanks for the patience!
:-)
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply.
| |