lkml.org 
[lkml]   [2015]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [V5 PATCH 2/4] panic/x86: Allow cpus to save registers even if they are looping in NMI context
    On Wed, Nov 25, 2015 at 09:46:37AM +0000, 河合英宏 / KAWAI,HIDEHIRO wrote:
    > Does *old* code mean the code without this patch *series* ?

    Yes.

    > I prefer this, but we might want to add some more prefix or suffix.
    > For example, "conditionally_run_crash_nmi_callback".

    That's unnecessary IMO. If you need to express that, you could write
    that in a comment above the function definition. Anyone who looks at
    the code then will know that it is conditional, like so many other
    kernel functions. :)

    > Thanks for your deep review!

    Thanks for the patience!

    :-)

    --
    Regards/Gruss,
    Boris.

    ECO tip #101: Trim your mails when you reply.


    \
     
     \ /
      Last update: 2015-11-25 11:21    [W:7.849 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site