Messages in this thread | | | Date | Wed, 25 Nov 2015 10:27:45 +0900 | From | Namhyung Kim <> | Subject | Re: [PATCH v12 01/30] tracing: Update cond flag when enabling or disabling a trigger |
| |
Hi Steve and Tom,
On Mon, Nov 23, 2015 at 04:29:43PM -0500, Steven Rostedt wrote: > On Mon, 23 Nov 2015 13:51:16 -0600 > Tom Zanussi <tom.zanussi@linux.intel.com> wrote: > > > When a trigger is enabled, the cond flag should be set beforehand, > > otherwise a trigger that's expecting to process a trace record > > (e.g. one with post_trigger set) could be invoked without one. > > > > Likewise a trigger's cond flag should be reset after it's disabled, > > not before. > > > > Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com> > > Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de> > > Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> > > Tested-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> > > --- > > FYI, I've applied this patch as it looks like something that should be > added regardless of the rest of the series.
You can add my Reviewed-by if you want. I'll try to review others soon.
Thanks, Namhyung
| |