Messages in this thread | | | Date | Tue, 24 Nov 2015 15:29:10 -0800 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] drivers: staging: vme: Fixed code style issues |
| |
On Fri, Nov 13, 2015 at 11:04:08PM +0000, Martyn Welch wrote: > > > On 13/11/15 20:01, Egor Uleyskiy wrote: > >From: Egor Uleyskiy <egor.ulieiskii@gmail.com> > > > >* Fixed indention > >* Deleted extra empty lines > >* Constructions that looks like > > card = kzalloc(sizeof(struct pio2_card), GFP_KERNEL); > > are changed to > > card = kzalloc(sizeof(*card), GFP_KERNEL); > Also: > > * Removing extra bracketing from uses of the address operator > * Use preferred null return check style
Ick, not good, please break this up into individual patches, one-per-type-of-fix.
thanks,
greg k-h
| |