Messages in this thread Patch in this message | | | From | Colin King <> | Subject | [PATCH] xprtrdma: add missing curly braces, set rc to zero on non-zero | Date | Tue, 24 Nov 2015 23:11:41 +0000 |
| |
From: Colin Ian King <colin.king@canonical.com>
Add the missing curly braces so that rc is only set to zero when it is non-zero. Without this minor fix, rc is set to zero even when it is zero, which is slightly redundant.
Detected with smatch static analysis.
Signed-off-by: Colin Ian King <colin.king@canonical.com> --- net/sunrpc/xprtrdma/verbs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c index eadd1655..2cc1014 100644 --- a/net/sunrpc/xprtrdma/verbs.c +++ b/net/sunrpc/xprtrdma/verbs.c @@ -852,10 +852,11 @@ retry: if (extras) { rc = rpcrdma_ep_post_extra_recv(r_xprt, extras); - if (rc) + if (rc) { pr_warn("%s: rpcrdma_ep_post_extra_recv: %i\n", __func__, rc); rc = 0; + } } } -- 2.6.2
| |