Messages in this thread | | | Subject | Re: [PATCH 1/5] lightnvm: change vendor and dev id for qemu | From | Jens Axboe <> | Date | Tue, 24 Nov 2015 15:21:03 -0700 |
| |
On 11/24/2015 11:24 AM, Matias Bjørling wrote: > On 11/24/2015 04:52 PM, Elliott, Robert (Persistent Memory) wrote: >> >> >>> -----Original Message----- >>> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel- >>> owner@vger.kernel.org] On Behalf Of Matias Bjørling >>> Sent: Tuesday, November 24, 2015 7:27 AM >> ... >>> Instead of using the Intel NVMe QEMU instance vendor and device id, >>> let's use a preallocated from CNEX Labs instead. This lets us >> ... >>> /* QEMU NVMe simulator - PCI ID + Vendor specific bit */ >>> - if (pdev->vendor == PCI_VENDOR_ID_INTEL && pdev->device == >>> 0x5845 && >>> + if (pdev->vendor == 0x1d1d && pdev->device == 0x1f1f && >>> id->vs[0] == 0x1) >> >> Could this patch add PCI_VENDOR_ID_CNEX to the appropriate .h file >> and use that instead? > > We could. But it would only be for this single use-case? Might be a > little overkill to put in pci_ids.h. Opt for lightnvm.h? or somewhere else?
Or just add a comment, this:
if (pdev->vendor == 0x1d1d && pdev->device == 0x1f1f
means nothing to anyone.
-- Jens Axboe
| |