| From | Arnd Bergmann <> | Subject | Re: [PATCH v1 11/13] mfd: intel-lpss: Pass HSUART configuration via properties | Date | Tue, 24 Nov 2015 20:53:04 +0100 |
| |
On Tuesday 24 November 2015 12:22:57 Andy Shevchenko wrote: > +static struct property_entry uart_properties[] = { > + PROPERTY_ENTRY_U32("reg-io-width", 4), > + PROPERTY_ENTRY_U32("reg-shift", 2), > + PROPERTY_ENTRY_U8("snps,uart-16550-compatible", 1), > + { }, >
If I read the binding correctly, the "snps,uart-16550-compatible" property is meant to be boolean, meaning true if present and zero-length or false if absent. Using a u8 propert instead feels wrong.
Maybe we can have a PROPERTY_ENTRY_BOOL() for that?
Arnd
|