Messages in this thread | | | From | Eric Anholt <> | Subject | Re: [PATCH] dmaengine: bcm2835-dma: Convert to use DMA pool | Date | Tue, 24 Nov 2015 10:34:13 -0800 |
| |
Peter Ujfalusi <peter.ujfalusi@ti.com> writes:
> f93178291712 dmaengine: bcm2835-dma: Fix memory leak when stopping a > running transfer > > Fixed the memleak, but introduced another issue: the terminate_all callback > might be called with interrupts disabled and the dma_free_coherent() is > not allowed to be called when IRQs are disabled. > Convert the driver to use dma_pool_* for managing the list of control > blocks for the transfer. > > Fixes: f93178291712 ("dmaengine: bcm2835-dma: Fix memory leak when stopping a running transfer") > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
It sounds like you got positive testing feedback. Using the DMA pool for our bcm2835_dma_cbs makes sense to me, too.
Reviewed-by: Eric Anholt <eric@anholt.net> [unhandled content-type:application/pgp-signature] | |