Messages in this thread | | | Subject | Re: [PATCH v5 1/8] watchdog: Introduce hardware maximum timeout in watchdog core | From | Guenter Roeck <> | Date | Tue, 24 Nov 2015 08:45:05 -0800 |
| |
Hi Uwe,
On 11/24/2015 08:11 AM, Uwe Kleine-König wrote: > Hello Guenter, > > On Tue, Nov 24, 2015 at 07:03:13AM -0800, Guenter Roeck wrote: >> thanks a lot for the Ack. I have v6 in the works, which changes recording >> of last_keepalive when the watchdog is started. Does your Ack include that >> change, or do you prefer to have another look ? > > this change is to sample jiffies before .start is called as I suggested, > right? For that change keeping my ack is ok of course. >
Correct. This is how the code now looks like.
started_at = jiffies; if (watchdog_hw_running(wdd) && wdd->ops->ping) err = wdd->ops->ping(wdd); else err = wdd->ops->start(wdd); if (err == 0) { set_bit(WDOG_ACTIVE, &wdd->status); wdd->last_keepalive = started_at; watchdog_update_worker(wdd); }
Thanks, Guenter
| |