Messages in this thread | | | Date | Tue, 24 Nov 2015 16:30:11 +0000 | From | Lee Jones <> | Subject | Re: [PATCH] mfd: constify da903x_chip_ops structure |
| |
On Fri, 13 Nov 2015, Julia Lawall wrote:
> The da903x_chip_ops structure is never modified, so declare it > as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > drivers/mfd/da903x.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/da903x.c b/drivers/mfd/da903x.c > index 37e4426..f6a0459 100644 > --- a/drivers/mfd/da903x.c > +++ b/drivers/mfd/da903x.c > @@ -60,7 +60,7 @@ struct da903x_chip_ops { > struct da903x_chip { > struct i2c_client *client; > struct device *dev; > - struct da903x_chip_ops *ops; > + const struct da903x_chip_ops *ops; > > int type; > uint32_t events_mask; > @@ -424,7 +424,7 @@ static irqreturn_t da903x_irq_handler(int irq, void *data) > return IRQ_HANDLED; > } > > -static struct da903x_chip_ops da903x_ops[] = { > +static const struct da903x_chip_ops da903x_ops[] = { > [0] = { > .init_chip = da9030_init_chip, > .unmask_events = da9030_unmask_events, >
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |