Messages in this thread Patch in this message | | | From | Joonsoo Kim <> | Subject | [PATCH] mm/compaction: __compact_pgdat() code cleanuup | Date | Tue, 24 Nov 2015 15:24:42 +0900 |
| |
This patch uses is_via_compact_memory() to distinguish direct compaction. And it also reduces indentation on compaction_defer_reset by filtering failure case. There is no functional change.
Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com> --- mm/compaction.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/mm/compaction.c b/mm/compaction.c index de3e1e7..2b1a15e 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1658,14 +1658,17 @@ static void __compact_pgdat(pg_data_t *pgdat, struct compact_control *cc) !compaction_deferred(zone, cc->order)) compact_zone(zone, cc); - if (cc->order > 0) { - if (zone_watermark_ok(zone, cc->order, - low_wmark_pages(zone), 0, 0)) - compaction_defer_reset(zone, cc->order, false); - } - VM_BUG_ON(!list_empty(&cc->freepages)); VM_BUG_ON(!list_empty(&cc->migratepages)); + + if (is_via_compact_memory(cc->order)) + continue; + + if (!zone_watermark_ok(zone, cc->order, + low_wmark_pages(zone), 0, 0)) + continue; + + compaction_defer_reset(zone, cc->order, false); } } -- 1.9.1
| |