Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH V2] cpufreq: Always remove sysfs cpuX/cpufreq link on ->remove_dev() | Date | Mon, 23 Nov 2015 23:47:24 +0100 |
| |
On Saturday, November 21, 2015 06:42:09 AM Srinivas Pandruvada wrote: > On Sat, 2015-11-21 at 09:06 +0530, Viresh Kumar wrote: > > Subsys interface's ->remove_dev() is called when the cpufreq driver > > is > > unregistering or the CPU is getting physically removed. We keep > > removing > > the cpuX/cpufreq link for all CPUs except the last one, which is a > > mistake as all CPUs contain a link now. > > > > Because of this, one CPU from each policy will still contain a link > > (to > > an already removed policyX directory), after the cpufreq driver is > > unregistered. > > > > Fix that by removing the link first and then only see if the policy > > is > > required to be freed. That will make sure that no links are left out. > > > > Fixes: 96bdda61f58b ("cpufreq: create cpu/cpufreq/policyX > > directories") > > Reported-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com > > Tested-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com
Applied, thanks!
Rafael
| |