lkml.org 
[lkml]   [2015]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 2/8] watchdog: Introduce WDOG_RUNNING flag
On Mon, Nov 23, 2015 at 08:26:06PM +0100, Uwe Kleine-König wrote:
> Hello Guenter,
>
> On Sun, Nov 22, 2015 at 07:20:59PM -0800, Guenter Roeck wrote:
> > diff --git a/include/linux/watchdog.h b/include/linux/watchdog.h
> > index b535b02b1d7f..f0292d56caf0 100644
> > --- a/include/linux/watchdog.h
> > +++ b/include/linux/watchdog.h
> > @@ -108,6 +108,7 @@ struct watchdog_device {
> > #define WDOG_ALLOW_RELEASE 2 /* Did we receive the magic char ? */
> > #define WDOG_NO_WAY_OUT 3 /* Is 'nowayout' feature set ? */
> > #define WDOG_UNREGISTERED 4 /* Has the device been unregistered */
> > +#define WDOG_RUNNING 5 /* True if HW watchdog running */
> > /* the following variables are for internal use only */
> > struct mutex lock;
> > unsigned long last_keepalive;
> > @@ -124,6 +125,12 @@ static inline bool watchdog_active(struct watchdog_device *wdd)
> > return test_bit(WDOG_ACTIVE, &wdd->status);
> > }
> >
> > +/* Use the following function to check whether or not the watchdog is running */
>
> I'd like to have this comment more clear to distinguish between device
> state and userspace view. Maybe also call the flag WDOG_HW_RUNNING to
> make this more clear?
>
Sure, I can make it WDOG_HW_RUNNING and watchdog_hw_running()
and clarify the comment.

Thanks,
Guenter


\
 
 \ /
  Last update: 2015-11-23 23:21    [W:0.198 / U:0.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site