lkml.org 
[lkml]   [2015]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 09/14] lib/test_printf.c: don't BUG
    Date
    BUG is a completely unnecessarily big hammer, and we're more likely to
    get the internal bug reported if we just pr_err() and ensure the test
    suite fails.

    Acked-by: Kees Cook <keescook@chromium.org>
    Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
    ---
    lib/test_printf.c | 7 ++++++-
    1 file changed, 6 insertions(+), 1 deletion(-)

    diff --git a/lib/test_printf.c b/lib/test_printf.c
    index c5a666af9ba5..9232a2add28c 100644
    --- a/lib/test_printf.c
    +++ b/lib/test_printf.c
    @@ -91,7 +91,12 @@ __test(const char *expect, int elen, const char *fmt, ...)
    int rand;
    char *p;

    - BUG_ON(elen >= BUF_SIZE);
    + if (elen >= BUF_SIZE) {
    + pr_err("error in test suite: expected output length %d too long. Format was '%s'.\n",
    + elen, fmt);
    + failed_tests++;
    + return;
    + }

    va_start(ap, fmt);

    --
    2.6.1


    \
     
     \ /
      Last update: 2015-11-23 22:41    [W:4.230 / U:0.260 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site