lkml.org 
[lkml]   [2015]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 1/2] block-rbd: Delete an unnecessary check before the function call "rbd_dev_destroy"
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Mon, 23 Nov 2015 20:16:45 +0100

    The rbd_dev_destroy() function tests whether its argument is NULL
    and then returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/block/rbd.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
    index 235708c..24a757e 100644
    --- a/drivers/block/rbd.c
    +++ b/drivers/block/rbd.c
    @@ -5184,8 +5184,7 @@ static int rbd_dev_probe_parent(struct rbd_device *rbd_dev, int depth)

    out_err:
    rbd_dev_unparent(rbd_dev);
    - if (parent)
    - rbd_dev_destroy(parent);
    + rbd_dev_destroy(parent);
    return ret;
    }

    --
    2.6.3


    \
     
     \ /
      Last update: 2015-11-23 22:41    [W:4.018 / U:0.352 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site