lkml.org 
[lkml]   [2015]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subjectstmmac: debugfs broken with multiple ethernets.
Hi!

stmmac_main will happily try to create two directories with the same
name.

I guess something like

static int id;
char name[100];

sprintf(name, STMMAC_RESOURCE_NAME "_%d", id++)
...

might be suitable, but did not try that further.

Best regards,

Pavel

--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
static int stmmac_init_fs(struct net_device *dev)
{
- /* Create debugfs entries */
+ /* Create debugfs entries: FIXME: this is broken with more
+ than one ethernet device. */
stmmac_fs_dir = debugfs_create_dir(STMMAC_RESOURCE_NAME,
NULL);

if (!stmmac_fs_dir || IS_ERR(stmmac_fs_dir)) {

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2015-11-23 17:01    [W:0.049 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site