lkml.org 
[lkml]   [2015]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] libertas: fix possible NULL dereference
    Date
    We were dereferencing cmd first and checking for NULL later. Lets first
    check for NULL.

    Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
    ---
    drivers/net/wireless/marvell/libertas/cfg.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/marvell/libertas/cfg.c b/drivers/net/wireless/marvell/libertas/cfg.c
    index 8317afd..e38ad1d 100644
    --- a/drivers/net/wireless/marvell/libertas/cfg.c
    +++ b/drivers/net/wireless/marvell/libertas/cfg.c
    @@ -1108,7 +1108,7 @@ static int lbs_associate(struct lbs_private *priv,
    size_t len, resp_ie_len;
    int status;
    int ret;
    - u8 *pos = &(cmd->iebuf[0]);
    + u8 *pos;
    u8 *tmp;

    lbs_deb_enter(LBS_DEB_CFG80211);
    @@ -1117,6 +1117,7 @@ static int lbs_associate(struct lbs_private *priv,
    ret = -ENOMEM;
    goto done;
    }
    + pos = &cmd->iebuf[0];

    /*
    * cmd 50 00
    --
    1.9.1


    \
     
     \ /
      Last update: 2015-11-23 13:41    [W:4.046 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site