Messages in this thread | | | Date | Mon, 23 Nov 2015 11:23:02 +0100 | From | Pablo Neira Ayuso <> | Subject | Re: [PATCH] netfilter: avoid harmless unnitialized variable warnings |
| |
On Thu, Nov 19, 2015 at 01:49:59PM +0100, Arnd Bergmann wrote: > Several ARM default configurations give us warnings on recent > compilers about potentially uninitialized variables in the > nfnetlink code in two functions: > > net/netfilter/nfnetlink_queue.c: In function 'nfqnl_build_packet_message': > net/netfilter/nfnetlink_queue.c:519:19: warning: 'nfnl_ct' may be used uninitialized in this function [-Wmaybe-uninitialized] > if (ct && nfnl_ct->build(skb, ct, ctinfo, NFQA_CT, NFQA_CT_INFO) < 0) > > Moving the rcu_dereference(nfnl_ct_hook) call outside of the > conditional code avoids the warning without forcing us to > preinitialize the variable.
Applied, thanks Arnd.
| |