lkml.org 
[lkml]   [2015]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drivers: staging: vme: Fixed code style issues
From
Date
On Sat, 2015-11-21 at 23:26 +0200, Egor Uleyskiy wrote:

trivia:
Some might consider this patch fixes too many issues in
one patch and should be broken up into a patch series.

> > diff --git a/drivers/staging/vme/devices/vme_pio2_core.c b/drivers/staging/vme/devices/vme_pio2_core.c
[]
> retval = vme_master_set(card->window, 1, card->base, 0x10000, VME_A24,
> - (VME_SCT | VME_USER | VME_DATA), VME_D16);
> + (VME_SCT | VME_USER | VME_DATA), VME_D16);

unnecessary parentheses around VME_ constants
> @@ -343,7 +343,7 @@ static int pio2_probe(struct vme_dev *vdev)
> retval = vme_irq_request(vdev, card->irq_level, vec,
> - &pio2_int, (void *)card);
> + &pio2_int, (void *)card);

unnecessary cast to (void *) here and in other places.

You could fix these in follow-on patch(es) or revisions
like a patch set of this one.



\
 
 \ /
  Last update: 2015-11-21 23:01    [W:0.200 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site