lkml.org 
[lkml]   [2015]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/3] clk: iproc: Add support for Cygnus audio clocks
From
Date


On 11/20/2015 4:21 PM, Stephen Boyd wrote:
> On 11/18, Ray Jui wrote:
>> diff --git a/drivers/clk/bcm/clk-iproc.h b/drivers/clk/bcm/clk-iproc.h
>> index 8988de7..e2a7748 100644
>> --- a/drivers/clk/bcm/clk-iproc.h
>> +++ b/drivers/clk/bcm/clk-iproc.h
>> @@ -194,5 +215,11 @@ void __init iproc_asiu_setup(struct device_node *node,
>> const struct iproc_asiu_div *div,
>> const struct iproc_asiu_gate *gate,
>> unsigned int num_clks);
>> +void __init iproc_audiopll_clk_setup(struct device_node *node,
>> + const struct iproc_pll_ctrl *pll_ctrl,
>> + const struct iproc_pll_vco_param *vco,
>> + unsigned int num_vco_entries,
>> + const struct iproc_clk_ctrl *clk_ctrl,
>> + unsigned int num_clks);
>
> We don't need __init in header files. And is this even used or
> defined anywhere?
>

Does it make more sense if I add an incremental patch to remove all of
the __init in this header?

Ah, this is a mistake. cygnus_audiopll_clk_init is already defined in
clk-cygnus.c and is meant to call iproc_pll_clk_setup to set up the
clock. iproc_pll_clk_setup is already declared in this header.

iproc_audiopll_clk_setup should be removed here.

Thanks,

Ray



\
 
 \ /
  Last update: 2015-11-21 02:21    [W:0.050 / U:7.360 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site