lkml.org 
[lkml]   [2015]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 net-next 1/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem

On 11/18/2015 6:52 PM, David Miller wrote:
> From: Salil <salil.mehta@huawei.com>
> Date: Wed, 18 Nov 2015 02:52:23 +0800
>
>> @@ -387,19 +409,23 @@ static void hns_rcb_ring_get_cfg(struct hnae_queue *q, int ring_type)
>> struct rcb_common_cb *rcb_common;
>> struct ring_pair_cb *ring_pair_cb;
>> u32 buf_size;
>> - u16 desc_num;
>> - int irq_idx;
>> + u16 desc_num, mdnum_ppkt;
>> + int irq_idx, is_ver1;
> Please use "bool" and true/false for boolean conditions like is_ver1.
>
> Please audit your entire submission for this problem.
Thanks for your time and comments. As per your suggestions, I have
changed the data type of variable "is_ver" to "bool" where ever possible
in the PATCH V3 floated yesterday.

Best Regards
Salil




\
 
 \ /
  Last update: 2015-11-20 15:41    [W:0.052 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site