lkml.org 
[lkml]   [2015]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option
    Hi,

    On 2015년 11월 02일 21:56, Daniel Lezcano wrote:
    > Let the platform's Kconfig to select the clock instead of having a reverse
    > dependency from the driver to the platform options.
    >
    > Add the COMPILE_TEST option for the compilation test coverage. Due to the
    > non portable 'delay' code, this driver is only compilable on ARM.
    >
    > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
    > ---
    > arch/arm/mach-exynos/Kconfig | 1 +
    > drivers/clocksource/Kconfig | 4 ++--
    > 2 files changed, 3 insertions(+), 2 deletions(-)
    >
    > diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
    > index 3a10f1a..ff10539 100644
    > --- a/arch/arm/mach-exynos/Kconfig
    > +++ b/arch/arm/mach-exynos/Kconfig
    > @@ -27,6 +27,7 @@ menuconfig ARCH_EXYNOS
    > select SRAM
    > select THERMAL
    > select MFD_SYSCON
    > + select CLKSRC_EXYNOS_MCT
    > help
    > Support for SAMSUNG EXYNOS SoCs (EXYNOS4/5)
    >
    > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
    > index 916c36d..d829cbe 100644
    > --- a/drivers/clocksource/Kconfig
    > +++ b/drivers/clocksource/Kconfig
    > @@ -213,8 +213,8 @@ config CLKSRC_METAG_GENERIC
    > This option enables support for the Meta per-thread timers.
    >
    > config CLKSRC_EXYNOS_MCT
    > - def_bool y if ARCH_EXYNOS
    > - depends on !ARM64
    > + bool "Exynos multi core timer driver" if COMPILE_TEST
    > + depends on ARM
    > help
    > Support for Multi Core Timer controller on Exynos SoCs.
    >
    >

    Looks good to me. As you commented, delay_timer is only used on ARM 32bit.
    I'm glad to use the 'depends on ARM' instead of reverse dependency.

    Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

    Thanks,
    Chanwoo Choi


    \
     
     \ /
      Last update: 2015-11-03 02:21    [W:2.439 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site