lkml.org 
[lkml]   [2015]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] comedi: drivers: Fix - BIT macro used coding style issue
On 02/11/15 14:25, ranjithece24@gmail.com wrote:
> From: Ranjith <ranjithece24@gmail.com>
>
> BIT macro is used for defining bit location instead of shifting
> operator - coding style issue
>
> Signed-off-by: Ranjith T <ranjithece24@gmail.com>
> ---
> drivers/staging/comedi/drivers/addi_apci_1032.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/addi_apci_1032.c b/drivers/staging/comedi/drivers/addi_apci_1032.c
> index b37166d..fd5ce21 100644
> --- a/drivers/staging/comedi/drivers/addi_apci_1032.c
> +++ b/drivers/staging/comedi/drivers/addi_apci_1032.c
> @@ -85,8 +85,8 @@
> #define APCI1032_STATUS_REG 0x0c
> #define APCI1032_CTRL_REG 0x10
> #define APCI1032_CTRL_INT_OR (0 << 1)
> -#define APCI1032_CTRL_INT_AND (1 << 1)
> -#define APCI1032_CTRL_INT_ENA (1 << 2)
> +#define APCI1032_CTRL_INT_AND BIT(1)
> +#define APCI1032_CTRL_INT_ENA BIT(2)
>
> struct apci1032_private {
> unsigned long amcc_iobase; /* base of AMCC I/O registers */
>

Hartley already fixed this coding style issue. It's in linux-next.

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-


\
 
 \ /
  Last update: 2015-11-02 16:01    [W:0.050 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site