Messages in this thread | | | Date | Fri, 20 Nov 2015 13:34:35 +1100 (AEDT) | From | James Morris <> | Subject | Re: [PATCH 2/2] keys, trusted: seal with a policy |
| |
On Wed, 18 Nov 2015, Jarkko Sakkinen wrote:
> On Wed, Nov 18, 2015 at 11:21:01AM +1100, James Morris wrote: > > On Tue, 17 Nov 2015, Jarkko Sakkinen wrote: > > > > > } > > > break; > > > + case Opt_policydigest: > > > + if (!tpm2 || > > > + strlen(args[0].from) != (2 * opt->digest_len)) > > > + return -EINVAL; > > > + kfree(opt->policydigest); > > > + opt->policydigest = kzalloc(opt->digest_len, > > > + GFP_KERNEL); > > > > Is it correct to kfree opt->policydigest here before allocating it? > > I think so. The same option might be encountered multiple times.
This would surely signify an error?
-- James Morris <jmorris@namei.org>
| |