Messages in this thread | | | Date | Fri, 20 Nov 2015 10:40:13 +0900 | From | Namhyung Kim <> | Subject | Re: [PATCH v5 7/9] perf hists browser: Support folded callchains |
| |
On Thu, Nov 19, 2015 at 11:19:38AM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Nov 09, 2015 at 02:45:44PM +0900, Namhyung Kim escreveu: > > The folded callchain mode is to print all chains in a single line. > > Currently perf report --tui doesn't support folded callchains. Like > > flat callchains, only leaf nodes are added to the final rbtree so it > > should show entries in parent nodes. To do that, add flat_val list to > > struct callchain_node and show them along with the (normal) val list. > > > > For example, folded callchain looks like below: > > > > $ perf report -g folded --tui > > Samples: 234 of event 'cycles:pp', Event count (approx.): 32605268 > > Overhead Command Shared Object Symbol > > - 39.93% swapper [kernel.vmlinux] [k] intel_idle > > + 28.63% intel_idle; cpuidle_enter_state; cpuidle_enter; ... > > + 11.30% intel_idle; cpuidle_enter_state; cpuidle_enter; ... > > The +/- before the folded callchains continue toggling, but with no, a > further polishment is to elide them altogether, since they have no use. > > Applied, that can be done on top.
Agreed.
Thanks, Namhyung
| |