lkml.org 
[lkml]   [2015]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] timer: relax tick stop in idle entry
On Thu, 19 Nov 2015 20:59:05 +0100
Peter Zijlstra <peterz@infradead.org> wrote:

> On Thu, Nov 19, 2015 at 11:21:25AM -0800, Jacob Pan wrote:
> > On Thu, 19 Nov 2015 20:06:30 +0100
> > Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > > Which one? That is, I cannot find a idle_cpu() call from
> > > tick_nohz_irq_exit().
> > it is tick_irq_exit(void), i will not call tick_nohz_irq_exit() if
> > !idle_cpu()
>
> Ah, but I think we really only need to test for the idle task there,
> the && need_resched() part of that function takes care of the rest.
>
> Once we have need_resched() set, we'll be on our way to
> tick_nohz_idle_exit() to restart the tick again.
Tested, it did the trick also. has less impact than changing idle_cpu().

My other point is the callers of idle_cpu() will see it returns false
but in forced idle. Can't see anything bad since we skip load balance.

Thanks,

Jacob


\
 
 \ /
  Last update: 2015-11-20 01:01    [W:0.672 / U:0.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site