lkml.org 
[lkml]   [2015]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: i915.ko WC writes are slow after ea8596bb2d8d379

* Chris Wilson <chris@chris-wilson.co.uk> wrote:

> > > A bisection pointed to
> > >
> > > commit ea8596bb2d8d37957f3e92db9511c50801689180
> > > Author: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> > > Date: Thu Jul 18 20:47:53 2013 +0900
> > >
> > > kprobes/x86: Remove unused text_poke_smp() and text_poke_smp_batch() functions
> > >
> > > of which the active ingredient was just
> > >
> > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> > > index b32ebf9..f4001e0 100644
> > > --- a/arch/x86/Kconfig
> > > +++ b/arch/x86/Kconfig
> > > @@ -2334,7 +2334,6 @@ config HAVE_ATOMIC_IOMAP
> > >
> > > config HAVE_TEXT_POKE_SMP
> > > bool
> > > - select STOP_MACHINE if SMP

Ouch...

This is certainly an educative example of how pure 'code removal' patches can have
unintended side effects.

Is there a full fix patch available, and is anyone pushing that to Linus?

Thanks,

Ingo


\
 
 \ /
  Last update: 2015-11-19 09:21    [W:0.096 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site