Messages in this thread | | | From | Måns Rullgård <> | Subject | Re: [PATCH v2 2/2] watchdog: add support for Sigma Designs SMP86xx/SMP87xx | Date | Thu, 19 Nov 2015 16:30:22 +0000 |
| |
Guenter Roeck <linux@roeck-us.net> writes:
>> + writel(WD_CONFIG_XTAL_IN, dev->base + WD_CONFIG); > > What happens if the DISABLE bit was previously set (assuming > that DISABLE means that the watchdog is disabled) ? > > Concern I guess would be the combination of DISABLE being set > and WD_COUNTER at a value != 0 (say, 1). That might effectively > auto-enable the watchdog or even reset the system.
There's no sane reason why it would be in that state, but then again firmware authors are not sane.
How about checking the DISABLE bit, and if it's set turn off the counter, otherwise leave it running?
-- Måns Rullgård mans@mansr.com
| |